[Fix] The interface multiscale_output is defined but not used #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kindly ping@Junjun2016 |
Let me help you @Junjun2016 |
|
Hi @AronLin |
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
==========================================
+ Coverage 88.73% 88.77% +0.04%
==========================================
Files 107 107
Lines 5805 5809 +4
Branches 932 933 +1
==========================================
+ Hits 5151 5157 +6
+ Misses 462 461 -1
+ Partials 192 191 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Junjun2016
reviewed
Aug 26, 2021
Junjun2016
reviewed
Aug 26, 2021
Junjun2016
approved these changes
Aug 27, 2021
|
Hi @AronLin |
Junjun2016
approved these changes
Aug 27, 2021
bowenroom
pushed a commit
to bowenroom/mmsegmentation
that referenced
this pull request
Feb 25, 2022
…mlab#830) * Add interface multiscale_output * Add space between args and their types * Fix default value
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
wjkim81
pushed a commit
to wjkim81/mmsegmentation
that referenced
this pull request
Dec 3, 2023
* Add unified SMPL-like model interface and builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface
multiscale_outputis defined in_make_stagebut never used.HRNet should be allowed to output a one-level feature in stage 4.
So we should use
multiscale_outputwhile making stage 4 and add interfacemultiscale_outputin the initialization function of HRNet.Add unit test for HRNet in this PR, too.